svn commit: r340196 - head

[Alex Richardson]

Author: arichardson
Date: Tue Nov  6 18:06:52 2018
New Revision: 340196
URL: https://svnweb.freebsd.org/changeset/base/340196

Log:
  Turn off BUILD_WITH_STRICT_TMPPATH by default
  
  Building with a strict $PATH (without inheriting from the parent
  environment) still causes build failures in some workflows/environemnts
  that I have not yet tested.
  I will try to bring this back once these issues have all been resolved
  since it is actually extremely useful in tracking broken dependencies
  and wrong assumptions about the build environemt.
  
  Discussed With:	brooks

Modified:
  head/Makefile.inc1

Modified: head/Makefile.inc1
==============================================================================
--- head/Makefile.inc1	Tue Nov  6 18:05:46 2018	(r340195)
+++ head/Makefile.inc1	Tue Nov  6 18:06:52 2018	(r340196)
@@ -589,12 +589,11 @@ STRICTTMPPATH=	${XPATH}:${BPATH}:${UNIVERSE_TOOLCHAIN_
 # the build to break on other systems that don't have that tool. For now we
 # still allow using the old behaviour (inheriting $PATH) if
 # BUILD_WITH_STRICT_TMPPATH is set to 0 but this will eventually be removed.
-.if ${USING_SYSTEM_LINKER} != "no" || ${USING_SYSTEM_COMPILER} != "no"
-# strict $PATH does not work yet with USING_SYSTEM_LINKER/USING_SYSTEM_COMPILER
+
+# Currently strict $PATH can cause build failures and does not work yet with
+# USING_SYSTEM_LINKER/USING_SYSTEM_COMPILER. Once these issues have been
+# resolved it will be turned on by default.
 BUILD_WITH_STRICT_TMPPATH?=0
-.else
-BUILD_WITH_STRICT_TMPPATH?=1
-.endif
 .if ${BUILD_WITH_STRICT_TMPPATH} != 0
 TMPPATH=	${STRICTTMPPATH}
 .else