svn commit: r340034 - in head/sys: compat/freebsd32 kern

Brooks Davis brooks at FreeBSD.org
Thu Nov 1 23:06:51 UTC 2018


Author: brooks
Date: Thu Nov  1 23:06:50 2018
New Revision: 340034
URL: https://svnweb.freebsd.org/changeset/base/340034

Log:
  Use mode_t when the documented signature does.
  
  This is more clear and produces better results when generating function
  stubs from syscalls.master.
  
  Reviewed by:	kib, emaste
  Obtained from:	CheribSD
  Sponsored by:	DARPA, AFRL
  Differential Revision:	https://reviews.freebsd.org/D17784

Modified:
  head/sys/compat/freebsd32/syscalls.master
  head/sys/kern/syscalls.master

Modified: head/sys/compat/freebsd32/syscalls.master
==============================================================================
--- head/sys/compat/freebsd32/syscalls.master	Thu Nov  1 23:01:24 2018	(r340033)
+++ head/sys/compat/freebsd32/syscalls.master	Thu Nov  1 23:06:50 2018	(r340034)
@@ -73,7 +73,7 @@
 4	AUE_WRITE	NOPROTO	{ ssize_t write(int fd, const void *buf, \
 				    size_t nbyte); }
 5	AUE_OPEN_RWTC	NOPROTO	{ int open(char *path, int flags, \
-				    int mode); }
+				    mode_t mode); }
 6	AUE_CLOSE	NOPROTO	{ int close(int fd); }
 7	AUE_WAIT4	STD	{ int freebsd32_wait4(int pid, int *status, \
 				    int options, struct rusage32 *rusage); }
@@ -85,7 +85,7 @@
 13	AUE_FCHDIR	NOPROTO	{ int fchdir(int fd); }
 14	AUE_MKNOD	COMPAT11 { int freebsd32_mknod(char *path, \
 					int mode, int dev); }
-15	AUE_CHMOD	NOPROTO	{ int chmod(char *path, int mode); }
+15	AUE_CHMOD	NOPROTO	{ int chmod(char *path, mode_t mode); }
 16	AUE_CHOWN	NOPROTO	{ int chown(char *path, int uid, int gid); }
 17	AUE_NULL	NOPROTO	{ caddr_t break(char *nsize); }
 18	AUE_GETFSSTAT	COMPAT4	{ int freebsd32_getfsstat( \
@@ -155,7 +155,7 @@
 				    size_t count); }
 59	AUE_EXECVE	STD	{ int freebsd32_execve(char *fname, \
 				    uint32_t *argv, uint32_t *envv); }
-60	AUE_UMASK	NOPROTO	{ int umask(int newmask); }
+60	AUE_UMASK	NOPROTO	{ int umask(mode_t newmask); }
 61	AUE_CHROOT	NOPROTO	{ int chroot(char *path); }
 62	AUE_FSTAT	COMPAT	{ int freebsd32_fstat(int fd, \
 				    struct ostat32 *ub); }
@@ -253,7 +253,7 @@
 				    struct timeval32 *tv, \
 				    struct timezone *tzp); }
 123	AUE_FCHOWN	NOPROTO	{ int fchown(int fd, int uid, int gid); }
-124	AUE_FCHMOD	NOPROTO	{ int fchmod(int fd, int mode); }
+124	AUE_FCHMOD	NOPROTO	{ int fchmod(int fd, mode_t mode); }
 125	AUE_RECVFROM	OBSOL	orecvfrom
 126	AUE_SETREUID	NOPROTO	{ int setreuid(int ruid, int euid); }
 127	AUE_SETREGID	NOPROTO	{ int setregid(int rgid, int egid); }
@@ -262,14 +262,14 @@
 					    int length); }
 130	AUE_FTRUNCATE	COMPAT|NOPROTO	{ int ftruncate(int fd, int length); }
 131	AUE_FLOCK	NOPROTO	{ int flock(int fd, int how); }
-132	AUE_MKFIFO	NOPROTO	{ int mkfifo(char *path, int mode); }
+132	AUE_MKFIFO	NOPROTO	{ int mkfifo(char *path, mode_t mode); }
 133	AUE_SENDTO	NOPROTO	{ int sendto(int s, caddr_t buf, \
 				    size_t len, int flags, caddr_t to, \
 				    int tolen); }
 134	AUE_SHUTDOWN	NOPROTO	{ int shutdown(int s, int how); }
 135	AUE_SOCKETPAIR	NOPROTO	{ int socketpair(int domain, int type, \
 				    int protocol, int *rsv); }
-136	AUE_MKDIR	NOPROTO	{ int mkdir(char *path, int mode); }
+136	AUE_MKDIR	NOPROTO	{ int mkdir(char *path, mode_t mode); }
 137	AUE_RMDIR	NOPROTO	{ int rmdir(char *path); }
 138	AUE_UTIMES	STD	{ int freebsd32_utimes(char *path, \
 				    struct timeval32 *tptr); }

Modified: head/sys/kern/syscalls.master
==============================================================================
--- head/sys/kern/syscalls.master	Thu Nov  1 23:01:24 2018	(r340033)
+++ head/sys/kern/syscalls.master	Thu Nov  1 23:06:50 2018	(r340034)
@@ -113,7 +113,7 @@
 		int open(
 		    _In_z_ char *path,
 		    int flags,
-		    int mode
+		    mode_t mode
 		);
 	}
 ; XXX should be		{ int open(const char *path, int flags, ...); }
@@ -170,7 +170,7 @@
 15	AUE_CHMOD	STD {
 		int chmod(
 		    _In_z_ char *path,
-		    int mode
+		    mode_t mode
 		);
 	}
 16	AUE_CHOWN	STD {
@@ -433,7 +433,7 @@
 	}
 60	AUE_UMASK	STD {
 		int umask(
-		    int newmask
+		    mode_t newmask
 		);
 	}
 61	AUE_CHROOT	STD {
@@ -788,7 +788,7 @@
 124	AUE_FCHMOD	STD {
 		int fchmod(
 		    int fd,
-		    int mode
+		    mode_t mode
 		);
 	}
 125	AUE_RECVFROM	COMPAT|NOARGS {
@@ -840,7 +840,7 @@
 132	AUE_MKFIFO	STD {
 		int mkfifo(
 		    _In_z_ char *path,
-		    int mode
+		    mode_t mode
 		);
 	}
 133	AUE_SENDTO	STD {
@@ -870,7 +870,7 @@
 136	AUE_MKDIR	STD {
 		int mkdir(
 		    _In_z_ char *path,
-		    int mode
+		    mode_t mode
 		);
 	}
 137	AUE_RMDIR	STD {


More information about the svn-src-all mailing list