svn commit: r334363 - head/usr.bin/elfdump

Shawn Webb shawn.webb at hardenedbsd.org
Wed May 30 12:10:44 UTC 2018


On Wed, May 30, 2018 at 01:16:50AM +0000, Ed Maste wrote:
> Author: emaste
> Date: Wed May 30 01:16:50 2018
> New Revision: 334363
> URL: https://svnweb.freebsd.org/changeset/base/334363
> 
> Log:
>   elfdump: chase ABI tag note name change from r232832
>   
>   r232832 changed the ABI tag note name from .note.ABI-tag to .note.tag.
>   Follow suit in elfdump.
>   
>   Elfdump's note parsing is very basic and should be significantly
>   reworked, but for now just restore the broken functionality.
>   
>   PR:		228290
>   Submitted by:	martin at lispworks.com
>   MFC after:	1 week
> 
> Modified:
>   head/usr.bin/elfdump/elfdump.c
> 
> Modified: head/usr.bin/elfdump/elfdump.c
> ==============================================================================
> --- head/usr.bin/elfdump/elfdump.c	Wed May 30 00:36:58 2018	(r334362)
> +++ head/usr.bin/elfdump/elfdump.c	Wed May 30 01:16:50 2018	(r334363)
> @@ -659,7 +659,7 @@ main(int ac, char **av)
>  		case SHT_NOTE:
>  			name = elf_get_word(e, v, SH_NAME);
>  			if (flags & ED_NOTE &&
> -			    strcmp(shstrtab + name, ".note.ABI-tag") == 0)
> +			    strcmp(shstrtab + name, ".note.tag") == 0)
>  				elf_print_note(e, v);
>  			break;
>  		case SHT_DYNSYM:

I wonder if it would be a good idea to handle .note.ABI-tag and
.note.tag so that it can handle binaries compiled both before and
after r232832.

Thanks,

-- 
Shawn Webb
Cofounder and Security Engineer
HardenedBSD

Tor-ified Signal:    +1 443-546-8752
Tor+XMPP+OTR:        lattera at is.a.hacker.sx
GPG Key ID:          0x6A84658F52456EEE
GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89  3D9E 6A84 658F 5245 6EEE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20180530/184949c2/attachment.sig>


More information about the svn-src-all mailing list