svn commit: r334229 - stable/11/sys/cam

[Ivan Klymenko]

В Sun, 27 May 2018 14:05:18 -0600
Sean Bruno <sbruno at freebsd.org> пишет:

> On 05/27/18 14:01, Ivan Klymenko wrote:
> > В Sun, 27 May 2018 11:21:16 -0600
> > Sean Bruno <sbruno at freebsd.org> пишет:
> >   
> >> On 05/27/18 02:16, Ivan Klymenko wrote:  
> >>> --- cam_iosched.o ---
> >>> /usr/local/libexec/ccache/world/cc -target
> >>> i386-unknown-freebsd11.2 --sysroot=/usr/obj/usr/src/tmp
> >>> -B/usr/obj/usr/src/tmp/usr/bin -O2 -pipe -O3 -fvectorize
> >>> -fslp-vectorize -fblocks -march=native -fno-strict-aliasing
> >>> -Werror -D_KERNEL -DKLD_MODULE -nostdinc
> >>> -DHAVE_KERNEL_OPTION_HEADERS
> >>> -include /usr/obj/usr/src/sys/k11/opt_global.h -I. -I/usr/src/sys
> >>> -fno-common -g -I/usr/obj/usr/src/sys/k11   -MD
> >>> -MF.depend.cam_iosched.o -MTcam_iosched.o -mno-mmx -mno-sse
> >>> -msoft-float -ffreestanding -fwrapv -fstack-protector -gdwarf-2
> >>> -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes
> >>> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef
> >>> -Wno-pointer-sign -D__printf__=__freebsd_kprintf__
> >>> -Wmissing-include-dirs -fdiagnostics-show-option
> >>> -Wno-unknown-pragmas -Wno-error-tautological-compare
> >>> -Wno-error-empty-body -Wno-error-parentheses-equality
> >>> -Wno-error-unused-function -Wno-error-pointer-sign
> >>> -Wno-error-shift-negative-value
> >>> -Wno-error-address-of-packed-member  -Ofast -fvectorize
> >>> -fslp-vectorize -fblocks -fcolor-diagnostics -mno-aes -mno-avx
> >>> -std=iso9899:1999 -c /usr/src/sys/cam/cam_iosched.c -o
> >>> cam_iosched.o /usr/src/sys/cam/cam_iosched.c:513:40: error: no
> >>> member named 'quanta1' in 'struct cam_iosched_softc'; did you
> >>> mean 'quanta'? callout_reset(&isc->ticker, hz / isc->quanta1,
> >>> cam_iosched_ticker, isc); ^~~~~~~ quanta    
> >>
> >>
> >> Is this a CCACHE failure?  I don't see this error on i386 builds
> >> kernel.
> >>
> >> sean
> >>  
> > 
> > Yes you are right. But such a long time did not happen with ccache.
> > 
> > Sorry.
> > 
> >   
> 
> 
> No problem.  Do you know why it failed?
> 
> sean
> 
Ops.
All the same, most likely because of this:

-	callout_reset(&isc->ticker, hz / isc->quanta - 1, cam_iosched_ticker, isc);
+	callout_reset(&isc->ticker, hz / isc->quanta1, cam_iosched_ticker, isc);
to

-	callout_reset(&isc->ticker, hz / isc->quanta - 1, cam_iosched_ticker, isc);
+	callout_reset(&isc->ticker, hz / isc->quanta, cam_iosched_ticker, isc);

ccache here not guilty.