svn commit: r333822 - head/sys/kern

[Warner Losh]

On Sat, May 19, 2018 at 9:39 AM, Matthew Macy <mmacy at freebsd.org> wrote:

>
> On Sat, May 19, 2018 at 07:17 Emmanuel Vadot <manu at bidouilliste.com>
> wrote:
>
>> On 2018-05-19 15:35, Rodney W. Grimes wrote:
>> > [ Charset UTF-8 unsupported, converting... ]
>> >> Author: mmacy
>> >> Date: Sat May 19 02:15:40 2018
>> >> New Revision: 333822
>> >> URL: https://svnweb.freebsd.org/changeset/base/333822
>> >>
>> >> Log:
>> >>   fix gcc8 unused variable and set but not used variable in unix
>> >> sockets
>> >>   add copyright from lock rewrite while here
>> >>
>> >> Modified:
>> >>   head/sys/kern/uipc_usrreq.c
>> >>
>> >> Modified: head/sys/kern/uipc_usrreq.c
>> >> ============================================================
>> ==================
>> >> --- head/sys/kern/uipc_usrreq.c      Sat May 19 00:47:24 2018
>> (r333821)
>> >> +++ head/sys/kern/uipc_usrreq.c      Sat May 19 02:15:40 2018
>> (r333822)
>> >> @@ -4,7 +4,7 @@
>> >>   * Copyright (c) 1982, 1986, 1989, 1991, 1993
>> >>   *  The Regents of the University of California.
>> >>   * Copyright (c) 2004-2009 Robert N. M. Watson
>> >> - * All rights reserved.
>> >
>> > Did you have permission from Robert Watson to remove this?
>> >
>> >> + * Copyright (c) 2018 Matthew Macy
>> >>   *
>> >>   * Redistribution and use in source and binary forms, with or without
>> >>   * modification, are permitted provided that the following conditions
>> > ...
>>
>>   That also seems a small patch to add your name in the copyright.
>>
>
> Uhh... Locking rewrite was a small patch? Really?
>

This specific change was trivial. However, rewriting the locking here was
non-trivial. The normal rule of thumb is about 25%, but that's flexible.
mmacy is responsible for about 14% of the file according to git blame (a
number that would be closer to 20% if you omitted the boilerplate parts of
the file). If all his changes were trivial variable initializations, then
I'd agree this fall short. But the new locking stuff is substantial enough
to meet our traditional requirements for adding a copyright line. It
affects the majority of the files and is a core functional feature of this
file.

Warner