svn commit: r333503 - stable/11/sys/net

Ian Lepore ian at freebsd.org
Fri May 11 23:37:08 UTC 2018


On Fri, 2018-05-11 at 19:31 -0400, Jonathan T. Looney wrote:
> On Fri, May 11, 2018 at 4:40 PM, Stephen Hurd <shurd at freebsd.org> wrote:
> > 
> > 
> > Author: shurd
> > Date: Fri May 11 20:40:26 2018
> > New Revision: 333503
> > URL: https://svnweb.freebsd.org/changeset/base/333503
> > 
> > Log:
> >   MFC r333329, r333366, r333373
> > 
> >   r333329: Fix off-by-one error requesting tx interrupt
> >   r333366: Cleanup queues when iflib_device_register fails
> >   r333373: Log iflib_tx_structures_setup failure in function
> > 
> Is this an acceptable style for MFC logs?
> 
> I'm asking because I actually prefer this to reading (or compiling) the
> concatenated log messages from several changes. However, I never knew it
> was acceptable to summarize like this. If it is, I'd like to know so I can
> adopt it for run-of-the-mill MFCs.
> 
> Jonathan

This used to be my preferred format, essentially to summarize what's
being mfc'd. But then I started using the MFC Tracker tool [*] and it
automatically generates a commit message that contains the full text,
so I stopped trying to summarize things.

[*] https://mfc.kernelnomicon.org/6/

-- Ian



More information about the svn-src-all mailing list