svn commit: r333393 - head/sys/contrib/ipfilter/netinet
Cy Schubert
Cy.Schubert at cschubert.com
Wed May 9 19:13:32 UTC 2018
In message <201805091907.w49J7Y0L003669 at slippy.cwsent.com>, Cy Schubert
writes:
> In message <4065288.o9QKfFzp22 at ralph.baldwin.cx>, John Baldwin writes:
> > On Wednesday, May 09, 2018 02:07:09 AM Cy Schubert wrote:
> > > Author: cy
> > > Date: Wed May 9 02:07:09 2018
> > > New Revision: 333393
> > > URL: https://svnweb.freebsd.org/changeset/base/333393
> > >
> > > Log:
> > > Document intentional fallthrough. (CID 976535)
> > >
> > > MFC after: 1 week
> > >
> > > Modified:
> > > head/sys/contrib/ipfilter/netinet/fil.c
> > >
> > > Modified: head/sys/contrib/ipfilter/netinet/fil.c
> > > =========================================================================
> ==
> > ===
> > > --- head/sys/contrib/ipfilter/netinet/fil.c Wed May 9 02:02:58 201
> 8
> > (r333392)
> > > +++ head/sys/contrib/ipfilter/netinet/fil.c Wed May 9 02:07:09 201
> 8
> > (r333393)
> > > @@ -1299,6 +1299,7 @@ ipf_pr_icmp(fin)
> > > }
> > > }
> > > #endif
> > > + /* fallthrough is intentional */
> > > case ICMP_SOURCEQUENCH :
> > > case ICMP_REDIRECT :
> > > case ICMP_TIMXCEED :
> >
> > Hmm, normal FreeBSD style here is to use /* FALLTHROUGH */, and there are
> > three other instances of that style in ipfilter already (and none others
> > using this comment style).
>
> Thanks John. It's been fixed in r333393.
s/r333393/r333427/
--
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX: <cy at FreeBSD.org> Web: http://www.FreeBSD.org
The need of the many outweighs the greed of the few.
More information about the svn-src-all
mailing list