svn commit: r333382 - head/sys/netinet

Michael Tuexen tuexen at freebsd.org
Tue May 8 20:40:43 UTC 2018


> On 8. May 2018, at 21:05, N.J. Mann <njm at njm.me.uk> wrote:
> 
> Hi,
> 
> 
> On Tuesday, May 08, 2018 18:48:52 +0000 Michael Tuexen <tuexen at FreeBSD.org> wrote:
>> Author: tuexen
>> Date: Tue May  8 18:48:51 2018
>> New Revision: 333382
>> URL: https://svnweb.freebsd.org/changeset/base/333382
>> 
>> Log:
>>  When reporting ERROR or ABORT chunks, don't use more data
>>  that is guaranteed to be contigous.
>                             ^^^^^^^^^
>                             contiguous
> 
> [...]
>> Modified: head/sys/netinet/sctputil.c
>> ==============================================================================
>> --- head/sys/netinet/sctputil.c	Tue May  8 18:25:37 2018	(r333381)
>> +++ head/sys/netinet/sctputil.c	Tue May  8 18:48:51 2018	(r333382)
>> @@ -2660,6 +2660,13 @@ sctp_notify_assoc_change(uint16_t state, struct sctp_t
>> 		notif_len = (unsigned int)sizeof(struct sctp_assoc_change);
>> 		if (abort != NULL) {
>> 			abort_len = ntohs(abort->ch.chunk_length);
>> +			/*
>> +			 * Only SCTP_CHUNK_BUFFER_SIZE are guaranteed to be
>> +			 * contiguos.
>                           ^^^^^^^^^
>                           contiguous
> 
> [...]
>> @@ -3565,6 +3572,13 @@ sctp_notify_remote_error(struct sctp_tcb *stcb, uint16
>> 	}
>> 	if (chunk != NULL) {
>> 		chunk_len = ntohs(chunk->ch.chunk_length);
>> +		/*
>> +		 * Only SCTP_CHUNK_BUFFER_SIZE are guaranteed to be
>> +		 * contiguos.
>                   ^^^^^^^^^
>                   contiguous
> 
Fixed in https://svnweb.freebsd.org/changeset/base/333386.

Thanks for the report.

Best regards
Michael
> Cheers,
>       Nick.
> -- 
> 



More information about the svn-src-all mailing list