svn commit: r328013 - head/sbin/fsck_ffs

Ian Lepore ian at freebsd.org
Fri Mar 9 22:31:33 UTC 2018


On Fri, 2018-03-09 at 17:09 -0500, Mark Johnston wrote:
> On Mon, Jan 15, 2018 at 07:25:11PM +0000, David Bright wrote:
> > 
> > Author: dab
> > Date: Mon Jan 15 19:25:11 2018
> > New Revision: 328013
> > URL: https://svnweb.freebsd.org/changeset/base/328013
> > 
> > Log:
> >   Exit fsck_ffs with non-zero status when file system is not repaired.
> >   
> > [...]
> etc/rc.d/fsck doesn't know how to interpret the new exit code and now
> just drops to a single-user shell when it is encountered. This is
> happening to me semi-regularly when my test systems crash, especially
> when I test kernel panic handling. :)
> 
> Is there any reason etc/rc.d/fsck shouldn't automatically retry (up to
> some configurable number of retries) when the new error code is seen?
> The patch below seems to do the trick for me:
> 

fsck_ffs already has a -R flag to automatically retry, wouldn't that be
a better mechanism for handling this new type of retry?

-- Ian



More information about the svn-src-all mailing list