svn commit: r330601 - head/sys/i386/ibcs2

[Warner Losh]

The message is right if you s/cloudabi/ibcs/ though.

Warner

On Wed, Mar 7, 2018 at 8:29 AM, Oliver Pinter <oliver.pinter at hardenedbsd.org
> wrote:

> Wrong commit message. IBCS isn't cloudabi.
>
> On Wednesday, March 7, 2018, Eitan Adler <eadler at freebsd.org> wrote:
>
>> Author: eadler
>> Date: Wed Mar  7 14:44:32 2018
>> New Revision: 330601
>> URL: https://svnweb.freebsd.org/changeset/base/330601
>>
>> Log:
>>   sys: Fix a few potential infoleaks in cloudabi
>>
>>   While there is no immediate leak, if the structure changes underneath
>>   us, there might be in the future.
>>
>>   Submitted by: Domagoj Stolfa <domagoj.stolfa at gmail.com>
>>   MFC After:    1 month
>>   Sponsored by: DARPA/AFRL
>>
>> Modified:
>>   head/sys/i386/ibcs2/ibcs2_ipc.c
>>
>> Modified: head/sys/i386/ibcs2/ibcs2_ipc.c
>> ============================================================
>> ==================
>> --- head/sys/i386/ibcs2/ibcs2_ipc.c     Wed Mar  7 14:41:29 2018
>> (r330600)
>> +++ head/sys/i386/ibcs2/ibcs2_ipc.c     Wed Mar  7 14:44:32 2018
>> (r330601)
>> @@ -135,6 +135,8 @@ ibcs2_msgctl(struct thread *td, void *v)
>>         struct msqid_ds bs;
>>         int error;
>>
>> +       memset(&is, 0, sizeof(is));
>> +
>>         switch (uap->cmd) {
>>         case IBCS2_IPC_STAT:
>>                 error = kern_msgctl(td, uap->msqid, IPC_STAT, &bs);
>> @@ -317,6 +319,8 @@ ibcs2_semctl(struct thread *td, void *v)
>>         union semun semun;
>>         register_t rval;
>>         int error;
>> +
>> +       memset(&is, 0, sizeof(is));
>>
>>         switch(uap->cmd) {
>>         case IBCS2_IPC_STAT:
>> _______________________________________________
>> svn-src-head at freebsd.org mailing list
>> https://lists.freebsd.org/mailman/listinfo/svn-src-head
>> To unsubscribe, send any mail to "svn-src-head-unsubscribe at freebsd.org"
>>
>