svn commit: r335608 - head/sbin/pfctl

Sean Bruno sbruno at FreeBSD.org
Sun Jun 24 21:19:09 UTC 2018


Author: sbruno
Date: Sun Jun 24 21:19:08 2018
New Revision: 335608
URL: https://svnweb.freebsd.org/changeset/base/335608

Log:
  Assuming that the intent (from the white space) is that the fprintf()
  be executed in the if() conditional.  If its not supposed to be printed
  inside the conditional, then the braces should be removed and the extra
  tabs on the fprintf() should be removed.
  
  Noted by cross compilation with gcc-mips.

Modified:
  head/sbin/pfctl/pfctl_altq.c

Modified: head/sbin/pfctl/pfctl_altq.c
==============================================================================
--- head/sbin/pfctl/pfctl_altq.c	Sun Jun 24 19:29:29 2018	(r335607)
+++ head/sbin/pfctl/pfctl_altq.c	Sun Jun 24 21:19:08 2018	(r335608)
@@ -497,12 +497,13 @@ cbq_compute_idletime(struct pfctl *pf, struct pf_altq 
 		 * this causes integer overflow in kernel!
 		 * (bandwidth < 6Kbps when max_pkt_size=1500)
 		 */
-		if (pa->bandwidth != 0 && (pf->opts & PF_OPT_QUIET) == 0)
+		if (pa->bandwidth != 0 && (pf->opts & PF_OPT_QUIET) == 0) {
 			warnx("queue bandwidth must be larger than %s",
 			    rate2str(ifnsPerByte * (double)opts->maxpktsize /
 			    (double)INT_MAX * (double)pa->ifbandwidth));
 			fprintf(stderr, "cbq: queue %s is too slow!\n",
 			    pa->qname);
+		}
 		nsPerByte = (double)(INT_MAX / opts->maxpktsize);
 	}
 


More information about the svn-src-all mailing list