svn commit: r335547 - head/usr.bin/top

Alexey Dokuchaev danfe at FreeBSD.org
Sat Jun 23 16:16:57 UTC 2018


On Fri, Jun 22, 2018 at 09:45:18AM +0000, Eitan Adler wrote:
> New Revision: 335547
> URL: https://svnweb.freebsd.org/changeset/base/335547
> 
> Log:
>   top(1): remove special handling of load > 5
>   
> ...
> Modified: head/usr.bin/top/screen.c
> ==============================================================================
> --- head/usr.bin/top/screen.c	Fri Jun 22 09:41:13 2018	(r335546)
> +++ head/usr.bin/top/screen.c	Fri Jun 22 09:45:18 2018	(r335547)
> @@ -55,7 +55,7 @@ static struct termios new_settings;
>  static char is_a_terminal = false;
>  
>  void
> -init_termcap(int interactive)
> +init_termcap(bool interactive)
>  {
>      char *bufptr;
>      char *PCptr;
> @@ -138,7 +138,7 @@ init_termcap(int interactive)
>      /* get "ce", clear to end */
>      if (!overstrike)
>      {
> -	clear_line = tgetstr("ce", &bufptr);
> +		clear_line = tgetstr("ce", &bufptr);
>      }

(I've seen it before, and replying to this commit as an example): would
you mind separating style and functional changes into different commits?
I know that top(1) is full of style bugs and it's very tempting to fix
them when you see them, but that's not really the best way to go.

./danfe


More information about the svn-src-all mailing list