svn commit: r335402 - head/sbin/veriexecctl

Jonathan T. Looney jtl at freebsd.org
Wed Jun 20 18:03:05 UTC 2018


On Wed, Jun 20, 2018 at 9:49 AM Stephen Kiernan <hackagadget at gmail.com>
wrote:
> And I was working on those sets of changes, when work and family didn't
> steal away time. I was told that some discussion happened at BSDCan this
> year in such that veriexec should go in as-is so it would be there, which
is why
> the commit happened (given the review was approved to land back in
January.)

I will readily admit that I was probably the source of this. My reasoning
was fairly simple: when a review has been open for over a year with no
action, it seems like the submitter should be able to commit it without
waiting for more review, if they are confident in their change. I stand by
that (and, in fact, would substitute something shorter for "over a year").

(Of course, if the submitter has other reasons for delaying the commit,
that's their prerogative, and I wasn't intending to push Steve to commit
this before he was ready.)

Jonathan


More information about the svn-src-all mailing list