svn commit: r333945 - head/usr.bin/top

[Bruce Evans]

On Thu, 14 Jun 2018, Eitan Adler wrote:

> On 10 June 2018 at 09:26, Alexey Dokuchaev <danfe at freebsd.org> wrote:
>> On Sun, Jun 10, 2018 at 08:56:24AM -0700, Eitan Adler wrote:
>>> On 10 June 2018 at 05:28, Alexey Dokuchaev <danfe at freebsd.org> wrote:
>>>> I've just tried the latest top(1).  Now it's even worse:
>>>> ...
>>>> Also, it is COMMA now.  Can we please do something about this?  I am not
>>>> calling for "USER PRI" as Bruce had suggested, but "USERNAME PRI" is just
>>>> about right.
>>>
>>> FWIW I have not forgotten about this. I am planning on completely
>>> rewriting how the header, and data, get displayed so its low my
>>> priority (pun intended) list to fix this specific case until then.
>>
>> Great!  Looking forward to improvements.  top(1) should be neat(TM).
>> Take your time Eitan, it's not that urgent.
>
> What do y'all think of https://reviews.freebsd.org/D15801 ? It changes
> the username length to 8 unconditionally. Its rolled into a rewrite of
> how the header gets created in order to actually make it
> understandable.

Hard-coded 8 is too simple.  Old versions were easy enough to understand,
but that depends on them mostly being hard-coded.  I don't like to review
anything that is not in mail.

Bruce