svn commit: r334864 - head/usr.bin/top

Florian Smeets flo at smeets.xyz
Sat Jun 9 06:13:18 UTC 2018


On 09.06.18 04:14, Eitan Adler wrote:
> Author: eadler
> Date: Sat Jun  9 02:14:33 2018
> New Revision: 334864
> URL: https://svnweb.freebsd.org/changeset/base/334864
> 
> Log:
>   top(1): use a different command to toggle tid vs pid

Thank you.

You cannot start top with -T unless you add something like the following:

Index: top.c
===================================================================
--- top.c	(revision 334874)
+++ top.c	(working copy)
@@ -328,7 +328,7 @@
 	    optind = 1;
 	}

-	while ((i = getopt(ac, av, "CSIHPabijJ:nquvzs:d:U:m:o:p:tw")) != EOF)
+	while ((i = getopt(ac, av, "CSIHPTabijJ:nquvzs:d:U:m:o:p:tw")) != EOF)
 	{
 	    switch(i)
 	    {

Another issue I just found is that if you start top with -P some columns
don't show any values:

CPU 0:  0.0% user,  0.0% nice,  0.0% system,  0.0% interrupt,  100% idle
CPU 1:  0.0% user,  0.0% nice,  0.0% system,  0.0% interrupt,  100% idle
CPU 2:     % user,     % nice,  1.2% system,     % interrupt, 98.8% idle
CPU 3:  0.4% user,     % nice,  0.4% system,     % interrupt, 99.2% idle
CPU 4:     % user,     % nice,  0.4% system,     % interrupt, 99.6% idle
CPU 5:     % user,     % nice,  2.4% system,     % interrupt, 97.6% idle
CPU 6:     % user,     % nice,  0.4% system,     % interrupt, 99.6% idle
CPU 7:     % user,     % nice,  2.4% system,     % interrupt, 97.6% idle

It is correct if you start top with -TP or -HP, or if you start top -P
and then use H or T to switch back and forth. I'm not sure in which
revision this was broken, it works with r333899.

Florian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20180609/41897176/attachment.sig>


More information about the svn-src-all mailing list