svn commit: r334630 - head/usr.bin/indent

Rodney W. Grimes freebsd at pdx.rh.CN85.dnsmgr.net
Tue Jun 5 00:00:25 UTC 2018


> Author: pstef
> Date: Mon Jun  4 20:24:31 2018
> New Revision: 334630
> URL: https://svnweb.freebsd.org/changeset/base/334630
> 
> Log:
>   indent(1): remove static const char copyright[]
>   
>   It repeats what is already said in the heading comment and it's optimized out
>   so serves no purpose.

The purpose would be to put a copyright into the binary, and why that is not
happening when the original authors intended that is not good.

This is a regression, as 5.4p8 shows:
{108}% strings /usr/bin/indent | grep -i copy
bcopy
@(#) Copyright (c) 1985 Sun Microsystems, Inc.
@(#) Copyright (c) 1976 Board of Trustees of the University of Illinois.
@(#) Copyright (c) 1980, 1993

Please walk very very very carefully around all things "copyright".

> Modified:
>   head/usr.bin/indent/indent.c
> 
> Modified: head/usr.bin/indent/indent.c
> ==============================================================================
> --- head/usr.bin/indent/indent.c	Mon Jun  4 20:21:51 2018	(r334629)
> +++ head/usr.bin/indent/indent.c	Mon Jun  4 20:24:31 2018	(r334630)
> @@ -35,14 +35,6 @@
>   * SUCH DAMAGE.
>   */
>  
> -#ifndef lint
> -static const char copyright[] =
> -"@(#) Copyright (c) 1985 Sun Microsystems, Inc.\n\
> -@(#) Copyright (c) 1976 Board of Trustees of the University of Illinois.\n\
> -@(#) Copyright (c) 1980, 1993\n\
> -	The Regents of the University of California.  All rights reserved.\n";
> -#endif /* not lint */
> -
>  #if 0
>  #ifndef lint
>  static char sccsid[] = "@(#)indent.c	5.17 (Berkeley) 6/7/93";
> 
> 

-- 
Rod Grimes                                                 rgrimes at freebsd.org


More information about the svn-src-all mailing list