svn commit: r334474 - head/usr.bin/top

Ronald Klop ronald-lists at klop.ws
Sun Jun 3 21:27:26 UTC 2018


On Sun, 03 Jun 2018 19:19:47 +0200, Florian Smeets via svn-src-all  
<svn-src-all at freebsd.org> wrote:

> On 01.06.18 07:51, Eitan Adler wrote:
>> Author: eadler
>> Date: Fri Jun  1 05:51:40 2018
>> New Revision: 334474
>> URL: https://svnweb.freebsd.org/changeset/base/334474
>>
>> Log:
>>   top(1): Display of TID when using 'H' flag
>>
>>   Some users prefer seeing the TID when viewing individual threads. This
>>   makes sense as the PID will be the same for multiple entries. An  
>> attempt
>>   was made to include both, but there is insufficient room. As such,  
>> using
>>   the TID.
>>
>>   While here, rename the header variables to be more understandable.
>>
>>   Discussed with:	mmacy
>>   Reported on:	2009-10-07
>>
>
> Hi,
>
> I think this is a mistake. The 'H' flag should keep the PID, AFAIK you
> cannot use the TID anywhere in top in contrast to the PID. I usually
> start top with the 'S' and 'H' flags. Now I cannot use 'k' to kill a
> process in that view, as I don't see the PID. IMHO showing TIDs should
> be a separate flag, 'h' maybe, as this commit changes current/expected
> behavior (POLA?).
>
> Also, this is not documented in the man page.
>
> Florian
>

+1 for Florian

I also like the PIDs to see which threads belong to the same process.

Ronald.


More information about the svn-src-all mailing list