svn commit: r334471 - head/tests/sys/audit
Alan Somers
asomers at FreeBSD.org
Fri Jun 1 01:37:09 UTC 2018
Author: asomers
Date: Fri Jun 1 01:37:07 2018
New Revision: 334471
URL: https://svnweb.freebsd.org/changeset/base/334471
Log:
audit(4): Add tests for the fr class of syscalls
readlink and readlinkat are the only syscalls in this class. open and
openat are as well, but they'll be handled in a different file. Also, tidy
up the copyright headers of recently added files in this area.
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D15636
Added:
head/tests/sys/audit/file-read.c (contents, props changed)
Modified:
head/tests/sys/audit/Makefile
head/tests/sys/audit/file-create.c
head/tests/sys/audit/utils.c
head/tests/sys/audit/utils.h
Modified: head/tests/sys/audit/Makefile
==============================================================================
--- head/tests/sys/audit/Makefile Fri Jun 1 01:35:54 2018 (r334470)
+++ head/tests/sys/audit/Makefile Fri Jun 1 01:37:07 2018 (r334471)
@@ -3,9 +3,12 @@
TESTSDIR= ${TESTSBASE}/sys/audit
ATF_TESTS_C= file-create
+ATF_TESTS_C+= file-read
SRCS.file-create+= file-create.c
SRCS.file-create+= utils.c
+SRCS.file-read+= file-read.c
+SRCS.file-read+= utils.c
TEST_METADATA+= timeout="30"
TEST_METADATA+= required_user="root"
Modified: head/tests/sys/audit/file-create.c
==============================================================================
--- head/tests/sys/audit/file-create.c Fri Jun 1 01:35:54 2018 (r334470)
+++ head/tests/sys/audit/file-create.c Fri Jun 1 01:37:07 2018 (r334471)
@@ -1,6 +1,5 @@
/*-
* Copyright 2018 Aniket Pandey
- * All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
Added: head/tests/sys/audit/file-read.c
==============================================================================
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ head/tests/sys/audit/file-read.c Fri Jun 1 01:37:07 2018 (r334471)
@@ -0,0 +1,136 @@
+/*-
+ * Copyright 2018 Aniket Pandey
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * SUCH DAMAGE.
+ *
+ * $FreeBSD$
+ */
+
+#include <atf-c.h>
+#include <fcntl.h>
+
+#include "utils.h"
+
+static struct pollfd fds[1];
+static char buff[1024];
+static const char *path = "fileforaudit";
+static const char *successreg = "fileforaudit.*return,success";
+static const char *failurereg = "fileforaudit.*return,failure";
+
+
+ATF_TC_WITH_CLEANUP(readlink_success);
+ATF_TC_HEAD(readlink_success, tc)
+{
+ atf_tc_set_md_var(tc, "descr", "Tests the audit of a successful "
+ "readlink(2) call");
+}
+
+ATF_TC_BODY(readlink_success, tc)
+{
+ memset(buff, 0, sizeof(buff));
+ ATF_REQUIRE_EQ(0, symlink("symlink", path));
+ FILE *pipefd = setup(fds, "fr");
+ ATF_REQUIRE(readlink(path, buff, sizeof(buff)-1) != -1);
+ check_audit(fds, successreg, pipefd);
+}
+
+ATF_TC_CLEANUP(readlink_success, tc)
+{
+ cleanup();
+}
+
+
+ATF_TC_WITH_CLEANUP(readlink_failure);
+ATF_TC_HEAD(readlink_failure, tc)
+{
+ atf_tc_set_md_var(tc, "descr", "Tests the audit of an unsuccessful "
+ "readlink(2) call");
+}
+
+ATF_TC_BODY(readlink_failure, tc)
+{
+ memset(buff, 0, sizeof(buff));
+ FILE *pipefd = setup(fds, "fr");
+ /* Failure reason: symbolic link does not exist */
+ ATF_REQUIRE_EQ(-1, readlink(path, buff, sizeof(buff)-1));
+ check_audit(fds, failurereg, pipefd);
+}
+
+ATF_TC_CLEANUP(readlink_failure, tc)
+{
+ cleanup();
+}
+
+
+ATF_TC_WITH_CLEANUP(readlinkat_success);
+ATF_TC_HEAD(readlinkat_success, tc)
+{
+ atf_tc_set_md_var(tc, "descr", "Tests the audit of a successful "
+ "readlinkat(2) call");
+}
+
+ATF_TC_BODY(readlinkat_success, tc)
+{
+ memset(buff, 0, sizeof(buff));
+ ATF_REQUIRE_EQ(0, symlink("symlink", path));
+ FILE *pipefd = setup(fds, "fr");
+ ATF_REQUIRE(readlinkat(AT_FDCWD, path, buff, sizeof(buff)-1) != -1);
+ check_audit(fds, successreg, pipefd);
+}
+
+ATF_TC_CLEANUP(readlinkat_success, tc)
+{
+ cleanup();
+}
+
+
+ATF_TC_WITH_CLEANUP(readlinkat_failure);
+ATF_TC_HEAD(readlinkat_failure, tc)
+{
+ atf_tc_set_md_var(tc, "descr", "Tests the audit of an unsuccessful "
+ "readlinkat(2) call");
+}
+
+ATF_TC_BODY(readlinkat_failure, tc)
+{
+ memset(buff, 0, sizeof(buff));
+ FILE *pipefd = setup(fds, "fr");
+ /* Failure reason: symbolic link does not exist */
+ ATF_REQUIRE_EQ(-1, readlinkat(AT_FDCWD, path, buff, sizeof(buff)-1));
+ check_audit(fds, failurereg, pipefd);
+}
+
+ATF_TC_CLEANUP(readlinkat_failure, tc)
+{
+ cleanup();
+}
+
+
+ATF_TP_ADD_TCS(tp)
+{
+ ATF_TP_ADD_TC(tp, readlink_success);
+ ATF_TP_ADD_TC(tp, readlink_failure);
+ ATF_TP_ADD_TC(tp, readlinkat_success);
+ ATF_TP_ADD_TC(tp, readlinkat_failure);
+
+ return (atf_no_error());
+}
Modified: head/tests/sys/audit/utils.c
==============================================================================
--- head/tests/sys/audit/utils.c Fri Jun 1 01:35:54 2018 (r334470)
+++ head/tests/sys/audit/utils.c Fri Jun 1 01:37:07 2018 (r334471)
@@ -1,6 +1,5 @@
/*-
* Copyright 2018 Aniket Pandey
- * All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
Modified: head/tests/sys/audit/utils.h
==============================================================================
--- head/tests/sys/audit/utils.h Fri Jun 1 01:35:54 2018 (r334470)
+++ head/tests/sys/audit/utils.h Fri Jun 1 01:37:07 2018 (r334471)
@@ -1,6 +1,5 @@
/*-
* Copyright 2018 Aniket Pandey
- * All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
More information about the svn-src-all
mailing list