svn commit: r336744 - in head: sbin/pfctl/tests/files share/mk

[Shawn Webb]

On Thu, Jul 26, 2018 at 11:11:05AM -0600, Brad Davis wrote:
> On Thu, Jul 26, 2018, at 11:09 AM, Shawn Webb wrote:
> > On Thu, Jul 26, 2018 at 05:05:34PM +0000, Brad Davis wrote:
> > > Author: brd
> > > Date: Thu Jul 26 17:05:33 2018
> > > New Revision: 336744
> > > URL: https://svnweb.freebsd.org/changeset/base/336744
> > > 
> > > Log:
> > >   Convert bsd.files.mk to support DIRS and simplify by only having one install
> > >   target.
> > >   
> > >   Also update the pfctl tests Makefile to work with this change.
> > >   
> > >   Approved by:	bapt (mentor)
> > >   Differential Revision:	https://reviews.freebsd.org/D16430
> > > 
> > > Modified:
> > >   head/sbin/pfctl/tests/files/Makefile
> > >   head/share/mk/bsd.files.mk
> > > 
> > > Modified: head/sbin/pfctl/tests/files/Makefile
> > > ==============================================================================
> > > --- head/sbin/pfctl/tests/files/Makefile	Thu Jul 26 16:51:23 2018	(r336743)
> > > +++ head/sbin/pfctl/tests/files/Makefile	Thu Jul 26 17:05:33 2018	(r336744)
> > > @@ -4,9 +4,7 @@ TESTSDIR=	${TESTSBASE}/sbin/pfctl/files
> > >  BINDIR=		${TESTSDIR}
> > >  
> > >  # We use ${.CURDIR} as workaround so that the glob patterns work.
> > > -FILES=		${.CURDIR}/pf????.in
> > > -FILES+=		${.CURDIR}/pf????.include
> > > -FILES+=		${.CURDIR}/pf????.ok
> > > +FILES!=		echo ${.CURDIR}/pf????.in ${.CURDIR}/pf????.include ${.CURDIR}/pf????.ok
> > 
> > Should this use ${ECHO} instead of echo?
> 
> No, that wouldn't work at all with the !=.

I thought that might be the case, but I just wanted to make sure.
Thanks for the clarification.

-- 
Shawn Webb
Cofounder and Security Engineer
HardenedBSD

Tor-ified Signal:    +1 443-546-8752
Tor+XMPP+OTR:        lattera at is.a.hacker.sx
GPG Key ID:          0x6A84658F52456EEE
GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89  3D9E 6A84 658F 5245 6EEE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20180726/c986ecb1/attachment.sig>