svn commit: r336526 - head

[Mark Johnston]

On Fri, Jul 20, 2018 at 07:32:52PM +0000, Li-Wen Hsu wrote:
> On Fri, Jul 20, 2018 at 14:40:56 -0400, Mark Johnston wrote:
> > On Fri, Jul 20, 2018 at 11:38:23AM -0600, Ian Lepore wrote:
> > > On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote:
> > > > Hi Ian,
> > > > 
> > > > -----Original Message-----
> > > > From: <owner-src-committers at freebsd.org> on behalf of Ian Lepore 
> > > > Date: 2018-07-19, Thursday at 17:44
> > > > To: <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, 
> > > > Subject: svn commit: r336526 - head
> > > > 
> > > > > 
> > > > > Author: ian
> > > > > Date: Fri Jul 20 00:44:04 2018
> > > > > New Revision: 336526
> > > > > URL: https://svnweb.freebsd.org/changeset/base/336526
> > > > > 
> > > > > Log:
> > > > >   Add ntpd to the list of users/groups to check before installing.
> > > > > 
> > > > > Modified:
> > > > >   head/Makefile.inc1
> > > > When trying to installworld:
> > > > 
> > > >     ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
> > > > 
> > > > But there is no UPDATING entry about this. (Also, shouldn't it be ${SRCTOP}/UPDATING?)
> > > > 
> > > > Thanks,
> > > > 
> > > > Ravi (rpokala@)
> > > 
> > > I wondered about that too, when I accidentally stumbled across the
> > > CHECK_UIDS thing and realized I should add ntpd to it. I searched in
> > > UPDATING for some of the other things in the CHECK_UIDS list to see
> > > what had been said about such changes in the past, even searching
> > > through old-old svn history, and found nothing.
> > > 
> > > I finally settled on the thought that the reference to UPDATING was to
> > > the stuff at the bottom that never changes. In particular to the
> > > section around line 1595 that documents the instalkernel, reboot,
> > > mergemaster, installworld sequence. The mergemaster part should take
> > > care of the new userid, I guess.
> > 
> > I thought it would too, but it's bombing out for me:
> > 
> > 	*** Creating the temporary root environment in /var/tmp/temproot
> > 	 *** /var/tmp/temproot ready for use
> > 	 *** Creating and populating directory structure in /var/tmp/temproot
> > 
> > 	mtree: unknown user `ntpd'
> > 	mtree: failed at line 49 of the specification
> > 
> > 	  *** FATAL ERROR: Cannot 'cd' to /home/mark/src/freebsd-dev and install files to
> > 	      the temproot environment
> > 
> > I see that line 49 of BSD.var.dist references the new uids, so I guess
> > there's a chicken and egg problem here?
> 
> I thought we should use mergemaster or etcupdate with -p for "pre-world"
> mode.

Oops, I'd forgotten about that flag.  That fixes it for me, thanks.