svn commit: r336514 - head/sys/dev/vt/hw/ofwfb

Nathan Whitehorn nwhitehorn at freebsd.org
Thu Jul 19 20:37:04 UTC 2018


Isn't stdout-path supposed to contain a string rather than an ihandle? 
This code assumes it is an ihandle (or xref phandle), which I think is 
wrong.
-Nathan

On 07/19/18 13:22, Justin Hibbits wrote:
> Author: jhibbits
> Date: Thu Jul 19 20:22:46 2018
> New Revision: 336514
> URL: https://svnweb.freebsd.org/changeset/base/336514
>
> Log:
>    ofwfb: Check for /chosen/stdout-path in addition to /chosen/stdout
>    
>    Some platforms use /chosen/stdout-path as the property containing the path to
>    the stdout node, not /chosen/stdout.
>
> Modified:
>    head/sys/dev/vt/hw/ofwfb/ofwfb.c
>
> Modified: head/sys/dev/vt/hw/ofwfb/ofwfb.c
> ==============================================================================
> --- head/sys/dev/vt/hw/ofwfb/ofwfb.c	Thu Jul 19 20:20:43 2018	(r336513)
> +++ head/sys/dev/vt/hw/ofwfb/ofwfb.c	Thu Jul 19 20:22:46 2018	(r336514)
> @@ -102,6 +102,10 @@ ofwfb_probe(struct vt_device *vd)
>   	if (OF_getprop(chosen, "stdout", &stdout, sizeof(stdout)) ==
>   	    sizeof(stdout))
>   		node = OF_instance_to_package(stdout);
> +	if (node == -1)
> +	    if (OF_getprop(chosen, "stdout-path", &stdout, sizeof(stdout)) ==
> +		sizeof(stdout))
> +		    node = OF_instance_to_package(stdout);
>   	if (node == -1) {
>   		/*
>   		 * The "/chosen/stdout" does not exist try
>



More information about the svn-src-all mailing list