svn commit: r335888 - in head: contrib/blacklist/bin lib/libpjdlog sbin/hastd

[John Baldwin]

On 7/4/18 7:25 PM, Ed Maste wrote:
> On 4 July 2018 at 20:55, Eitan Adler <lists at eitanadler.com> wrote:
>> On Tue, 3 Jul 2018 at 08:22, John Baldwin <jhb at freebsd.org> wrote:
>>>
>>  since GCC usually breaks
>>> them.
>>
>> Could you explain what you mean or point to a prior conversation?
>>
> I'm not sure if there's a previous discussion, but the short version
> is that the GCC build process includes a 'fixincludes' step which
> installs modified versions of system headers in some path that GCC
> uses in preference to /usr/include. Originally this was done to work
> around broken system includes in proprietary operating systems that
> couldn't easily be fixed upstream. In the case of FreeBSD GCC's
> fixincludes actually just installs broken headers, and removing its
> broken copies is the easy fix.

Worse, the headers in include-fixed don't get updated if you install a
new world with updated system headers, so you can get weird compile
issues because GCC from ports is using stale copies of headers.
It's generally a hack for ancient OS's that isn't relevant on FreeBSD.
The issues that fixincludes thinks it finds and needs to fix aren't
legitimate issues AFAIK (and if they were we'd want to fix our real
headers instead).

-- 
John Baldwin