svn commit: r335833 - in head: share/man/man4 sys/net sys/netpfil/pf

[Kristof Provost]

On 3 Jul 2018, at 7:38, Antoine Brodin wrote:
> On Sun, Jul 1, 2018 at 3:16 AM, Will Andrews <will at freebsd.org> wrote:
>> Author: will
>> Date: Sun Jul  1 01:16:03 2018
>> New Revision: 335833
>> URL: https://svnweb.freebsd.org/changeset/base/335833
>>
>> Log:
>>   pf: remove unused ioctls.
>>
>>   Several ioctls are unused in pf, in the sense that no base utility
>>   references them.  Additionally, a cursory review of pf-based ports
>>   indicates they're not used elsewhere either.  Some of them have 
>> been
>>   unused since the original import.  As far as I can tell, they're 
>> also
>>   unused in OpenBSD.  Finally, removing this code removes the need 
>> for
>>   future pf work to take them into account.
>>
>>   Reviewed by:          kp
>>   Differential Revision:        https://reviews.freebsd.org/D16076
>>
>> Modified:
>>   head/share/man/man4/pf.4
>>   head/sys/net/pfvar.h
>>   head/sys/netpfil/pf/pf_ioctl.c
>
> Hi,
>
> This breaks some ports like net/libdnet,   please revert or fix the
> ports fallout.
>
It also uses DIOCCHANGERULE (like sshuttle).

Do you know of any other failures?
It’d be good to know if reverting just the DIOCCHANGERULE removal 
would be enough to fix all failures, or if there are others that are 
used as well.

Regards,
Kristof