svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev/...

[Warner Losh]

On Wed, Jan 24, 2018 at 1:50 AM, Bruce Evans <brde at optusnet.com.au> wrote:

> On Tue, 23 Jan 2018, Pedro Giffuni wrote:
>
> On 23/01/2018 14:08, Conrad Meyer wrote:
>>
>>> Hi Pedro,
>>>
>>> On Sun, Jan 21, 2018 at 7:42 AM, Pedro F. Giffuni <pfg at freebsd.org>
>>> wrote:
>>>
>>>> Author: pfg
>>>> Date: Sun Jan 21 15:42:36 2018
>>>> New Revision: 328218
>>>> URL: https://svnweb.freebsd.org/changeset/base/328218
>>>>
>>>> Log:
>>>>    Revert r327828, r327949, r327953, r328016-r328026, r328041:
>>>>    Uses of mallocarray(9).
>>>>
>>>>    The use of mallocarray(9) has rocketed the required swap to build
>>>> FreeBSD.
>>>>    This is likely caused by the allocation size attributes which put
>>>> extra pressure
>>>>    on the compiler.
>>>>
>>> I'm confused about this change.  Wouldn't it be better to remove the
>>> annotation/attributes from mallocarray() than to remove the protection
>>> against overflow?
>>>
>>
> It would be better to remove mallocarray().


I agree completely. It doesn't do what you think it is doing, for all the
reasons that Bruce outlines. We thought it was a bad idea when it came up 2
years ago and nothing has really changed.

Warner