svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev/...

[Conrad Meyer]

Hi Pedro,

On Sun, Jan 21, 2018 at 7:42 AM, Pedro F. Giffuni <pfg at freebsd.org> wrote:
> Author: pfg
> Date: Sun Jan 21 15:42:36 2018
> New Revision: 328218
> URL: https://svnweb.freebsd.org/changeset/base/328218
>
> Log:
>   Revert r327828, r327949, r327953, r328016-r328026, r328041:
>   Uses of mallocarray(9).
>
>   The use of mallocarray(9) has rocketed the required swap to build FreeBSD.
>   This is likely caused by the allocation size attributes which put extra pressure
>   on the compiler.

I'm confused about this change.  Wouldn't it be better to remove the
annotation/attributes from mallocarray() than to remove the protection
against overflow?  (If the compiler is fixed in the future to not use
excessive memory with these attributes, they can be conditionalized on
compiler version, of course.)

Best,
Conrad