svn commit: r327354 - head/sys/vm

[Conrad Meyer]

On Thu, Jan 18, 2018 at 12:01 PM, Eric van Gyzen <eric at vangyzen.net> wrote:
> On 01/17/2018 16:40, Gleb Smirnoff wrote:
>> Yeah, style is sacred, but is there a single person on Earth who would
>> not agree that moving variables from smaller blocks to function block
>> reduces readability of the code?
>
> I agree that it reduces the readability.  Not only that, it also
> encourages real bugs by allowing access to the variable when it does not
> make sense.

I think the right way to propose this kind of policy change is to get
agreement on how style(9) should be modified — not arbitrarily go
against style(9) in some files.  The proposed change may be somewhat
contentious and it might be a good exercise to go through the FreeBSD
Community Process.

I might separate these two concerns:

1. Allowing local / block scoped variables
2. Allowing C99 for loop initial declarations

But I could see the argument that (2) is just a boring subset of (1).

Thanks,
Conrad