svn commit: r327949 - in head/sys/dev: aacraid advansys ath beri/virtio bnxt bwn ciss cxgbe/crypto esp fb gpio if_ndis iwi kbd liquidio liquidio/base mpr mps mpt mrsas mxge netmap nvme pst ral rp s...

Eitan Adler lists at eitanadler.com
Tue Jan 16 04:34:53 UTC 2018


On 14 January 2018 at 12:16, Warner Losh <imp at bsdimp.com> wrote:

> On Jan 14, 2018 10:15 AM, "Mark Johnston" <markj at freebsd.org> wrote:
>
> On Sat, Jan 13, 2018 at 05:34:24PM -0500, Pedro Giffuni wrote:
> >
> >
> > On 01/13/18 17:30, Pedro F. Giffuni wrote:
> > > Author: pfg
> > > Date: Sat Jan 13 22:30:30 2018
> > > New Revision: 327949
> > > URL: https://svnweb.freebsd.org/changeset/base/327949
> > >
> > > Log:
> > >    dev: make some use of mallocarray(9).
> > >
> > >    Focus on code where we are doing multiplications within malloc(9).
> None of
> > >    these is likely to overflow, however the change is still useful as
> some
> > >    static checkers can benefit from the allocation attributes we use
> for
> > >    mallocarray.
> > >
> > >    This initial sweep only covers malloc(9) calls with M_NOWAIT. No
> good
> > >    reason but I started doing the changes before r327796 and at that
> time it
> > >    was convenient to make sure the sorrounding code could handle NULL
> values.
> > >
> > For the record, this was part of
> >
> > https://reviews.freebsd.org/D13837
> >
> > I didn't mention it in the commit log because I am not ready to close
> > the revision yet.
>
> Some developers have been using the "X-Differential revision:" tag in
> this case.
>
>
> I just list it per normal, but reopen the review if I need to.
>

If you keep the D#### in the message, phabricator will add a connection to
the commit, even if you don't include the full "Differential Revision'
line.


-- 
Eitan Adler


More information about the svn-src-all mailing list