svn commit: r330004 - in head/stand: . arm efi forth i386 mips powerpc sparc64

[Kyle Evans]

n Tue, Feb 27, 2018 at 9:28 AM, Kyle Evans <kevans at freebsd.org> wrote:
> On Sun, Feb 25, 2018 at 9:16 PM, Warner Losh <imp at freebsd.org> wrote:
>> Author: imp
>> Date: Mon Feb 26 03:16:04 2018
>> New Revision: 330004
>> URL: https://svnweb.freebsd.org/changeset/base/330004
>>
>> Log:
>>   Add NO_OBJ to those directories that don't make anything.
>>
>>   For directories that don't many anything, add NO_OBJ=t just before we
>>   include bsd.init.mk. This prevents them from creating an OBJ
>>   directory. In addition, prevent defs.mk from creating the machine
>>   related links in these cases. They aren't needed and break, at least
>>   on stable, the read-only src tree build.
>>
>
> Any objection to also removing efi from i386 SUBDIR? It seems silly
> to be explicitly adding it when we know nothing here is applicable and
> it's going to take some amount of work to get there.

In fact, this block [1] feels wrong, too... why are we adding efi to
SUBDIR for arch's that don't support it? I understand the GCC checks,
but libefi, loader, and boot1 are the main bits of efi/, why are these
stuck behind MACHINE_CPUARCH checks?

[1] https://svnweb.freebsd.org/base/head/stand/efi/Makefile?view=markup#l17