svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme

[Warner Losh]

On Thu, Feb 22, 2018 at 9:49 AM, Wojciech Macek <wma at semihalf.com> wrote:

> Yes, I'm doing that right now. So far it seems everything is there, but
> will confirm to be 100% sure.
>
> Warner, I'm very sorry for not waiting for your comments. The review was
> dead for few days and I thought that all was already said, but maybe
> should have waited a little longer...
> Let me know what to do now. If you see any issues, I'll be more than happy
> to fix them. Also, if you insist, we can revert it, but if no drastic
> changes are required, I'd prefer to leave it as is and make iterational
> fixes to this part.
>

I agree. Unless something surfaces that's utterly broken, that's the best
path forward. So far the actual driver is coping well with the load I'm
giving it and it wasn't too disruptive to other things I had going on.... I
understand things get pushed in more quickly than reviews would like
sometimes, so I'll look over the changes and see if all of the things I had
issues with in the original patches were addressed. I know most of them
have, but wanted to make sure before a final sign off is all... If there is
stuff, I think it will be minor.

Warner


> Regards,
> Wojtek
> wma@
>
> 2018-02-22 17:34 GMT+01:00 Warner Losh <imp at bsdimp.com>:
>
>> I know all about losing things during the rebase....
>>
>> I'd be a lot happier if you could confirm that nothing else was lost.
>> It's a large patch, which makes it impossible for others to do it...  It
>> seems to build, and seems to be working in the light testing I've done this
>> morning...
>>
>> Warner
>>
>>
>> On Thu, Feb 22, 2018 at 9:31 AM, Wojciech Macek <wma at semihalf.com> wrote:
>>
>>> Thanks and sorry for troubles!
>>> These lines must have got lost somewhere during rebase as we run
>>> tinderbox with this patch yesterday.
>>>
>>> Regards,
>>> Wojtek
>>> wma@
>>>
>>> 2018-02-22 17:22 GMT+01:00 Alan Somers <asomers at freebsd.org>:
>>>
>>>> On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans <kevans at freebsd.org> wrote:
>>>>
>>>>> On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers <asomers at freebsd.org>
>>>>> wrote:
>>>>> > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek <wma at freebsd.org>
>>>>> wrote:
>>>>> >
>>>>> >> Author: wma
>>>>> >> Date: Thu Feb 22 13:32:31 2018
>>>>> >> New Revision: 329824
>>>>> >> URL: https://svnweb.freebsd.org/changeset/base/329824
>>>>> >>
>>>>> >> Log:
>>>>> >>   NVMe: Add big-endian support
>>>>> >>
>>>>> >>   Remove bitfields from defined structures as they are not portable.
>>>>> >>   Instead use shift and mask macros in the driver and nvmecontrol
>>>>> >> application.
>>>>> >>
>>>>> >>   NVMe is now working on powerpc64 host.
>>>>> >>
>>>>> >>   Submitted by:          Michal Stanek <mst at semihalf.com>
>>>>> >>   Obtained from:         Semihalf
>>>>> >>   Reviewed by:           imp, wma
>>>>> >>   Sponsored by:          IBM, QCM Technologies
>>>>> >>   Differential revision: https://reviews.freebsd.org/D13916
>>>>> >>
>>>>> >
>>>>> > It looks like this change broke the build with Clang:
>>>>> >
>>>>>
>>>>> Fixed in r329827... all little endian arch's broken, not so great. =(
>>>>>
>>>>
>>>> Fast work, Kyle.  Thanks a bundle.
>>>> -Alan
>>>>
>>>
>>>
>>
>