svn commit: r329776 - vendor-sys/illumos/dist/uts/common/fs/zfs

Alexander Motin mav at FreeBSD.org
Thu Feb 22 00:59:51 UTC 2018


Author: mav
Date: Thu Feb 22 00:59:49 2018
New Revision: 329776
URL: https://svnweb.freebsd.org/changeset/base/329776

Log:
  8477 Assertion failed in vdev_state_dirty(): spa_writeable(spa)
  
  illumos/illumos-gate at f4c1745bd6c9829a05ecec15759ede7757100ab5
  
  Illumos 4080 allows "zpool clear" to work on readonly pools: i don't think
  this is the intended behaviour, we shouldn't be allowed to clear readonly
  pools. Probably.
  
  A fix is already in the ZFS on Linux repository to addess this issue:
  https://github.com/zfsonlinux/zfs/commit/92e43c17188d47f47b69318e4884096dec380e36
  
  Reviewed by: Matthew Ahrens <mahrens at delphix.com>
  Approved by: Dan McDonald <danmcd at joyent.com>
  Author: loli10K <ezomori.nozomu at gmail.com>

Modified:
  vendor-sys/illumos/dist/uts/common/fs/zfs/zfs_ioctl.c

Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/zfs_ioctl.c
==============================================================================
--- vendor-sys/illumos/dist/uts/common/fs/zfs/zfs_ioctl.c	Thu Feb 22 00:55:25 2018	(r329775)
+++ vendor-sys/illumos/dist/uts/common/fs/zfs/zfs_ioctl.c	Thu Feb 22 00:59:49 2018	(r329776)
@@ -5900,7 +5900,7 @@ zfs_ioctl_init(void)
 	    zfs_secpolicy_config, B_TRUE, POOL_CHECK_NONE);
 
 	zfs_ioctl_register_pool(ZFS_IOC_CLEAR, zfs_ioc_clear,
-	    zfs_secpolicy_config, B_TRUE, POOL_CHECK_NONE);
+	    zfs_secpolicy_config, B_TRUE, POOL_CHECK_READONLY);
 	zfs_ioctl_register_pool(ZFS_IOC_POOL_REOPEN, zfs_ioc_pool_reopen,
 	    zfs_secpolicy_config, B_TRUE, POOL_CHECK_SUSPENDED);
 


More information about the svn-src-all mailing list