svn commit: r329737 - head/stand/i386/boot2

Colin Percival cperciva at tarsnap.com
Wed Feb 21 18:46:47 UTC 2018


On 02/21/18 10:10, Benno Rice wrote:
>   Curiously, changing whitespace seems to cause the md5 of the .o files to differ
>   these days hence the following testing strategy:
>   
>   Tested by:	objdump -d | md5 (both in-tree clang and lang/gcc6)

Is this simply because line numbers are changing?  That isn't new; I remember
a case where a security advisory touched a .h file and suddenly a huge number
of binaries changed because they included header file line numbers.

>  static inline int
>  strcmp(const char *s1, const char *s2)
>  {
> -    for (; *s1 == *s2 && *s1; s1++, s2++);
> -    return (unsigned char)*s1 - (unsigned char)*s2;
> +
> +	for (; *s1 == *s2 && *s1; s1++, s2++);
> +	return (unsigned char)*s1 - (unsigned char)*s2;
>  }

-- 
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid


More information about the svn-src-all mailing list