svn commit: r329237 - head/sys/libkern

Ed Maste emaste at freebsd.org
Tue Feb 13 19:43:26 UTC 2018


On 13 February 2018 at 14:23, Ian Lepore <ian at freebsd.org> wrote:
> On Tue, 2018-02-13 at 19:17 +0000, Ed Maste wrote:
>> Author: emaste
>> Date: Tue Feb 13 19:17:48 2018
>> New Revision: 329237
>> URL: https://svnweb.freebsd.org/changeset/base/329237
>>
>> Log:
>>   libkern: use nul for terminating char rather than 0
>>
>>   Akin to the change made in r188080 for lib/libc/string/.
>>
>>   Reported by:        bde
>>   Sponsored by:       The FreeBSD Foundation
>
> There are many ways to spell 0.  Why are we using something other than
> the simplest way?  Is it a style rule thing, or is it portability-
> correctness, or what?

I made the change to improve consistency between lib/libc/string and
sys/libkern, which is what Bruce commented on some time ago. I don't
have a personal preference for 0 or '\0' but definitely believe that
if we have multiple, similar copies of a function they ought to avoid
gratuitous differences. (I'm happy to change both trees to 0 if that's
preferred.)


More information about the svn-src-all mailing list