svn commit: r329164 - in head: include sys/amd64/include sys/i386/include sys/mips/include sys/powerpc/include sys/sparc64/include

Warner Losh imp at bsdimp.com
Mon Feb 12 16:07:35 UTC 2018


On Mon, Feb 12, 2018 at 8:57 AM, Joerg Sonnenberger <joerg at bec.de> wrote:

> On Mon, Feb 12, 2018 at 02:48:14PM +0000, Warner Losh wrote:
> > Author: imp
> > Date: Mon Feb 12 14:48:14 2018
> > New Revision: 329164
> > URL: https://svnweb.freebsd.org/changeset/base/329164
> >
> > Log:
> >   We don't support gcc < 4.2.1, so varargs.h now is just #error
> >   always. Unifdef for versions prior to 4.2.1 and remove now-unused
> >   header files.
>
> In my experience it is better to really drop it. Keeping the header with
> an #error is just creating *more* pain than having no header at all.
>

My change didn't change anything here. It already was a #error. I just
changed it from #if <always true> #error #endif to #error. I'll leave it to
the compliance folks to jump in and remove it. It's a posix header, it
seems. But nobody is using it and it can't be causing widespread problems
today or it would be on people's radar... It's not.

Warner


More information about the svn-src-all mailing list