svn commit: r327058 - head/stand/efi/boot1

Kyle Evans kevans at freebsd.org
Mon Feb 12 14:47:14 UTC 2018


On Thu, Dec 21, 2017 at 6:21 AM, Michael Zhilin <mizhka at freebsd.org> wrote:
> Author: mizhka
> Date: Thu Dec 21 12:21:35 2017
> New Revision: 327058
> URL: https://svnweb.freebsd.org/changeset/base/327058
>
> Log:
>   [boot/efi] scan all display modes rather than sequential try-fail way
>
>   This patch allows to scan all display modes in boot1 as loader does.
>
>   Before system tried to select optimal display mode by sequential scan of
>   modes and if error then stop scanning. This way is not good, because
>   if mode N is not present, mode N+1 may exist.
>
>   In loader we use conout->Mode->MaxMode to identify maximum number of modes.
>   This commit is to use same way in boot1 as in loader.
>
>   Reported by:  Andrey Pustovetov <andrey.pustovetov at gmail.com>
>   Reviewed by:  tsoome
>   Differential Revision:        https://reviews.freebsd.org/D13541
>

HI,

Just FYI- we've had several reports of this doing the wrong thing for
many people, most recently by Allan yesterday (IIRC). I'm going to
avoid MFC'ing it, I think we should either back this out or figure out
where it's going wrong sooner rather than later. =(

Thanks,

Kyle Evans


More information about the svn-src-all mailing list