svn commit: r328610 - head/sys/amd64/amd64

[Ed Maste]

On 31 January 2018 at 11:14, John Baldwin <jhb at freebsd.org> wrote:
> On Wednesday, January 31, 2018 10:31:36 AM Ed Maste wrote:
>> On 30 January 2018 at 21:01, John Baldwin <jhb at freebsd.org> wrote:
>> > On Tuesday, January 30, 2018 11:29:27 PM John Baldwin wrote:
>> >> Author: jhb
>> >> Date: Tue Jan 30 23:29:27 2018
>> >> New Revision: 328610
>> >> URL: https://svnweb.freebsd.org/changeset/base/328610
>> >>
>> >> Log:
>> >>   Ensure 'name' is not NULL before passing to strcmp().
>> >>
>> >>   This avoids a nested page fault when obtaining a stack trace in DDB if
>> >>   the address from the first frame does not resolve to a known symbol.
>> >>
>> >>   MFC after:  1 week
>> >>   Sponsored by:       Chelsio Communications
>> >
>> > This appears to be fallout from lld?  After fixing this, the stack trace
>> > for my next panic shows no symbols for functions in the kernel, only
>> > functions in kernel modules:
>>
>> It's fallout from loader changes in r328536. I reverted r328536 (and
>> r328603) locally and stack traces are fixed.
>
> Ouch.  I'll try to look at this later today unless someone else beats me to
> it.

I committed a band-aid fix in r328826 but it still needs more
investigation / proper fix.