svn commit: r328707 - stable/11/sbin/nvmecontrol

Alexander Motin mav at FreeBSD.org
Thu Feb 1 19:30:03 UTC 2018


Author: mav
Date: Thu Feb  1 19:30:02 2018
New Revision: 328707
URL: https://svnweb.freebsd.org/changeset/base/328707

Log:
  MFC r308848 (by imp):
  Remove check for valid log pages. Let the drive tell us which pages
  are valid or not. While many pages are reserved in the standard, that
  doesn't make them invalid and future versions of the standard may
  define then.

Modified:
  stable/11/sbin/nvmecontrol/logpage.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sbin/nvmecontrol/logpage.c
==============================================================================
--- stable/11/sbin/nvmecontrol/logpage.c	Thu Feb  1 19:28:00 2018	(r328706)
+++ stable/11/sbin/nvmecontrol/logpage.c	Thu Feb  1 19:30:02 2018	(r328707)
@@ -757,14 +757,6 @@ logpage(int argc, char *argv[])
 				    "\"%s\" not valid log page id.\n",
 				    optarg);
 				logpage_usage();
-			/* TODO: Define valid log page id ranges in nvme.h? */
-			} else if (log_page == 0 ||
-				   (log_page >= 0x04 && log_page <= 0x7F) ||
-				   (log_page >= 0x80 && log_page <= 0xBF)) {
-				fprintf(stderr,
-				    "\"%s\" not valid log page id.\n",
-				    optarg);
-				logpage_usage();
 			}
 			pageflag = true;
 			break;


More information about the svn-src-all mailing list