svn commit: r342304 - stable/12/sys/dev/sfxge/common

[Andrew Rybchenko]

Author: arybchik
Date: Fri Dec 21 14:52:46 2018
New Revision: 342304
URL: https://svnweb.freebsd.org/changeset/base/342304

Log:
  MFC r340826
  
  sfxge(4): fix ignoring function return value
  
  fix PreFAST issue, add missing annotation that function return value
  should not be ignored. Fix alignment.
  
  Submitted by:   Andy Moreton <amoreton at solarflare.com>
  Sponsored by:   Solarflare Communications, Inc.
  Differential Revision:  https://reviews.freebsd.org/D18096

Modified:
  stable/12/sys/dev/sfxge/common/efx.h
  stable/12/sys/dev/sfxge/common/efx_phy.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/sfxge/common/efx.h
==============================================================================
--- stable/12/sys/dev/sfxge/common/efx.h	Fri Dec 21 14:50:18 2018	(r342303)
+++ stable/12/sys/dev/sfxge/common/efx.h	Fri Dec 21 14:52:46 2018	(r342304)
@@ -913,13 +913,13 @@ efx_phy_media_type_get(
 	__in		efx_nic_t *enp,
 	__out		efx_phy_media_type_t *typep);
 
-extern					efx_rc_t
+extern	__checkReturn		efx_rc_t
 efx_phy_module_get_info(
-	__in				efx_nic_t *enp,
-	__in				uint8_t dev_addr,
-	__in				uint8_t offset,
-	__in				uint8_t len,
-	__out_bcount(len)		uint8_t *data);
+	__in			efx_nic_t *enp,
+	__in			uint8_t dev_addr,
+	__in			uint8_t offset,
+	__in			uint8_t len,
+	__out_bcount(len)	uint8_t *data);
 
 #if EFSYS_OPT_PHY_STATS
 

Modified: stable/12/sys/dev/sfxge/common/efx_phy.c
==============================================================================
--- stable/12/sys/dev/sfxge/common/efx_phy.c	Fri Dec 21 14:50:18 2018	(r342303)
+++ stable/12/sys/dev/sfxge/common/efx_phy.c	Fri Dec 21 14:52:46 2018	(r342304)
@@ -301,7 +301,7 @@ efx_phy_media_type_get(
 		*typep = epp->ep_fixed_port_type;
 }
 
-	__checkReturn	efx_rc_t
+	__checkReturn		efx_rc_t
 efx_phy_module_get_info(
 	__in			efx_nic_t *enp,
 	__in			uint8_t dev_addr,