svn commit: r341464 - head/sbin/savecore

[Warner Losh]

On Tue, Dec 4, 2018 at 11:14 AM Rodney W. Grimes <
freebsd at pdx.rh.cn85.dnsmgr.net> wrote:

> > On Tue, Dec 4, 2018 at 9:28 AM Rodney W. Grimes
> > >
> > > > Author: garga (ports committer)
> > > > Date: Tue Dec  4 12:34:22 2018
> > > > New Revision: 341464
> > > > URL: https://svnweb.freebsd.org/changeset/base/341464
> > > >
> > > > Log:
> > > >   Restore /var/crash permissions to 0750, as declared in mtree file.
> After
> > > >   r337337 it changed to 0755.
> > > >
> > > >   Reviewed by:        loos
> > > >   Approved by:        loos
> > > >   MFC after:  3 days
> > > >   Sponsored by:       Rubicon Communications, LLC (Netgate)
> > > >   Differential Revision:      https://reviews.freebsd.org/D18355
> > >
> > > This probably warrants an EN against 12.0 release.
> >
> > Can we just fix it before 12.0-RELEASE builds starts?  It would be
> > much more robust compared to delivering a "fixit" script though
> > freebsd-update...
>
> Thats Glens call, but normal procedure is 0 change between
> last RC and release.
>

Let's not be too pedantic here: This is a security issue and let's not let
our process get in the way of fixing a simple security issue.

Warner


> (Bcc:'ed to gjb@, and trimmed a bit)
>
> Rod
> > > > +++ head/sbin/savecore/Makefile       Tue Dec  4 12:34:22 2018
>   (r341464)
> > > > @@ -2,7 +2,9 @@
> > > >
> > > >  PACKAGE=runtime
> > > >  CONFS=       minfree
> > > > -CONFSDIR=    /var/crash
> > > > +VAR_CRASH=   /var/crash
> > > > +VAR_CRASH_MODE=      0750
> > > > +CONFSDIR=    VAR_CRASH
> > > >  PROG=        savecore
> > > >  LIBADD=      z xo
> > > >  MAN= savecore.8
> --
> Rod Grimes
> rgrimes at freebsd.org
>
>