svn commit: r337776 - head/sys/netinet6

Kristof Provost kp at FreeBSD.org
Thu Aug 30 22:12:43 UTC 2018


On 31 Aug 2018, at 0:07, Bjoern A. Zeeb wrote:
> On 30 Aug 2018, at 22:00, Kristof Provost wrote:
>> I’ve done this, which fixes the problem:
>>
>> 	diff --git a/sys/netinet6/frag6.c b/sys/netinet6/frag6.c
>> 	index 0f30801540a..e1f2b3f5842 100644
>> 	--- a/sys/netinet6/frag6.c
>> 	+++ b/sys/netinet6/frag6.c
>> 	@@ -218,7 +218,9 @@ frag6_input(struct mbuf **mp, int *offp, int 
>> proto)
>> 	        int offset = *offp, nxt, i, next;
>> 	        int first_frag = 0;
>> 	        int fragoff, frgpartlen;        /* must be larger than 
>> u_int16_t */
>> 	-       uint32_t hash, hashkey[sizeof(struct in6_addr) * 2 + 1], 
>> *hashkeyp;
>> 	+       uint32_t hashkey[(sizeof(struct in6_addr) * 2 + 
>> sizeof(u_int32_t)) /
>
> Can we actually make it the size of the field rather than uint32_t 
> (not u_int32_t)?  I guess not easily but at least change the type 
> spelling and leave a comment what it is?
>
I think we can spell that `sizeof(ip6f->ip6f_ident))`, yes.

Kristof


More information about the svn-src-all mailing list