svn commit: r338130 - head/sys/dev/mly

John Baldwin jhb at FreeBSD.org
Tue Aug 21 10:08:13 UTC 2018


Author: jhb
Date: Tue Aug 21 10:08:12 2018
New Revision: 338130
URL: https://svnweb.freebsd.org/changeset/base/338130

Log:
  De-spl mly(4).
  
  The driver already has mutex locking and holds its per-softc lock across
  calls to the one function that still used splcam().

Modified:
  head/sys/dev/mly/mly.c

Modified: head/sys/dev/mly/mly.c
==============================================================================
--- head/sys/dev/mly/mly.c	Tue Aug 21 09:35:56 2018	(r338129)
+++ head/sys/dev/mly/mly.c	Tue Aug 21 10:08:12 2018	(r338130)
@@ -1215,7 +1215,6 @@ mly_fetch_event(struct mly_softc *sc)
 {
     struct mly_command		*mc;
     struct mly_command_ioctl	*mci;
-    int				s;
     u_int32_t			event;
 
     debug_called(1);
@@ -1237,14 +1236,11 @@ mly_fetch_event(struct mly_softc *sc)
      * Get an event number to fetch.  It's possible that we've raced with another
      * context for the last event, in which case there will be no more events.
      */
-    s = splcam();
     if (sc->mly_event_counter == sc->mly_event_waiting) {
 	mly_release_command(mc);
-	splx(s);
 	return;
     }
     event = sc->mly_event_counter++;
-    splx(s);
 
     /* 
      * Build the ioctl.


More information about the svn-src-all mailing list