svn commit: r337956 - in head: . bin/ls

[Kyle Evans]

On Fri, Aug 17, 2018 at 10:26 AM, Kyle Evans <kevans at freebsd.org> wrote:
> On Fri, Aug 17, 2018 at 10:24 AM, Rodney W. Grimes
> <freebsd at pdx.rh.cn85.dnsmgr.net> wrote:
>> [ Charset UTF-8 unsupported, converting... ]
>>> Author: kevans
>>> Date: Fri Aug 17 04:15:51 2018
>>> New Revision: 337956
>>> URL: https://svnweb.freebsd.org/changeset/base/337956
>>>
>>> Log:
>>>   ls(1): Add --color=when
>>>
>>>   --color may be set to one of: 'auto', 'always', and 'never'.
>>>
>>>   'auto' is the default behavior- output colors only if -G or COLORTERM are
>>
>> Why different than coreutils ls?   Default for coreutils is none.
>
> I guess this was worded poorly and you skipped both the review and
> reading the diff... this is still contingent on environment variables
> or -G being specified.
>
>>>   set, and only if stdout is a tty.
>>>
>>>   'always' is a new behavior- output colors always. termcap(5) will be
>>>   consulted unless TERM is unset or not a recognized terminal, in which case
>>>   ls(1) will fall back to explicitly outputting ANSI escape sequences.
>>>
>>>   'never' to turn off any environment variable and -G usage.
>> Why different than core utils?  Coreutils uses none.
>
> I guess this was worded poorly and you skipped both the review and
> reading the diff... this is still contingent on environment variables
> or -G being specified.
>

... copy-paste-o. The version of coreutils ls(1) that I have uses
'never' for this. There is no valid 'none' value.