svn commit: r337791 - in head: crypto/openssl crypto/openssl/apps crypto/openssl/crypto crypto/openssl/crypto/asn1 crypto/openssl/crypto/bio crypto/openssl/crypto/bn crypto/openssl/crypto/bn/asm cr...

Thu Aug 16 19:31:11 UTC 2018

On 8/16/18 12:14 PM, Ian Lepore wrote:
> On Thu, 2018-08-16 at 12:10 -0700, Bryan Drewery wrote:
>> On 8/16/18 11:47 AM, Larry Rosenman wrote:
>>>
>>> On Thu, Aug 16, 2018 at 11:34:59AM -0700, Bryan Drewery wrote:
>>>>
>>>> On 8/16/18 11:21 AM, Larry Rosenman wrote:
>>>>>
>>>>> On Thu, Aug 16, 2018 at 02:02:52PM -0400, Jung-uk Kim wrote:
>>>>>>
>>>>>> On 18. 8. 16., Larry Rosenman wrote:
>>>>>>>
>>>>>>> On Thu, Aug 16, 2018 at 01:48:40PM -0400, Jung-uk Kim
>>>>>>> wrote:
>>>>>>>>
>>>>>>>> On 18. 8. 16., Ravi Pokala wrote:
>>>>>>>>>
>>>>>>>>> -----Original Message-----
>>>>>>>>> From: <owner-src-committers at freebsd.org> on behalf of
>>>>>>>>> Jung-uk Kim <jkim at FreeBSD.org>
>>>>>>>>> Date: 2018-08-14, Tuesday at 10:48
>>>>>>>>> To: <src-committers at freebsd.org>, <svn-src-all at freebsd.
>>>>>>>>> org>, <svn-src-head at freebsd.org>
>>>>>>>>> Subject: svn commit: r337791 - in head: crypto/openssl
>>>>>>>>> crypto/openssl/apps crypto/openssl/crypto
>>>>>>>>> crypto/openssl/crypto/asn1 crypto/openssl/crypto/bio
>>>>>>>>> crypto/openssl/crypto/bn crypto/openssl/crypto/bn/asm
>>>>>>>>> cr...
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Author: jkim
>>>>>>>>>> Date: Tue Aug 14 17:48:02 2018
>>>>>>>>>> New Revision: 337791
>>>>>>>>>> URL: https://svnweb.freebsd.org/changeset/base/337791
>>>>>>>>>>
>>>>>>>>>> Log:
>>>>>>>>>>   Merge OpenSSL 1.0.2p.
>>>>>>>>> Is it just me, or did this change break all the worlds?
>>>>>>>>>
>>>>>>>>> I got errors like this:
>>>>>>>>>
>>>>>>>>> -----------------------------------------------------
>>>>>>>>> -----------
>>>>>>>>> /usr/bin/ld: error: undefined symbol: main
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> referenced by crt1.c:74
>>>>>>>>>>>> (/usr/home/rpokala/freebsd/clean/base/head/lib/cs
>>>>>>>>>>>> u/amd64/crt1.c:74)
>>>>>>>>>>>>               /build/usr/home/rpokala/freebsd/cle
>>>>>>>>>>>> an/base/head/amd64.amd64/tmp/usr/lib/crt1.o:(_sta
>>>>>>>>>>>> rt)
>>>>>>>>> /usr/bin/ld: error: undefined symbol: Fssh_error
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> referenced by moduli.c:257
>>>>>>>>>>>> (/usr/home/rpokala/freebsd/clean/base/head/crypto
>>>>>>>>>>>> /openssh/moduli.c:257)
>>>>>>>>>>>>               /tmp/moduli-
>>>>>>>>>>>> 6780ab.o:(Fssh_gen_candidates)
>>>>>>>>> -----------------------------------------------------
>>>>>>>>> -----------
>>>>>>>>>
>>>>>>>>> At first I thought it was because I was rebuilding
>>>>>>>>> without cleaning, but I nuked the tree and rebuilt from
>>>>>>>>> scratch, and got the same error.
>>>>>>>>>
>>>>>>>>> I didn't bisect it to this change, but it's the only
>>>>>>>>> recent change to crypto...
>>>>>>>> I built worlds many times and I haven't seen such
>>>>>>>> problem.  In fact,
>>>>>>>> Jenkins didn't break on amd64 after the commit.
>>>>>>>>
>>>>>>>> https://ci.freebsd.org/job/FreeBSD-head-amd64-build/9888/
>>>>>>> Do you or jenkins run with meta-mode?  That seems to be a
>>>>>>> necessary
>>>>>>> condition for the failure.
>>>>>> I don't do meta-mode.  I don't know much about Jenkins build
>>>>>> but I don't
>>>>>> think it does.  Is it a requirement now?
>>>>>>
>>>> Jenkins doesn't use META_MODE and it's not a requirement.
>>> Can you (bdrewery@) possibly diagnose why meta-mode is messing this
>>> up
>>> with the moduli file?
>>>
>>>>
>>>>
>> Sure. I'm hitting it as well.
>>
>>
> 
> There's a thread about it in -current@ too.
> 
> -- Ian
> 

META_MODE is a distraction here, it fails without it in a clean build.
The current@ thread explains why due to moduli.c being in the .PATH now.

> ~/git/freebsd/secure/usr.sbin/sshd # make buildconfig -dmM MK_META_MODE=no
> Make_ExpandUse: examine buildconfig
> MakeAddChild: need to examine moduli
> MakeAddChild: need to examine sshd_config
> Make_ExpandUse: examine moduli
> MakeAddChild: need to examine moduli.c
> Make_ExpandUse: examine sshd_config
> Make_ExpandUse: examine moduli.c
> Examining moduli.c...modified  7:59:30 Jun 07, 2018...up-to-date.
> Examining moduli...modified  0:00:00 Nov 30, 2017...modified before source /root/git/freebsd/crypto/openssh/moduli.c...out-of-date.
> cc -O2 -pipe   -I/root/git/freebsd/crypto/openssh -include ssh_namespace.h -DHAVE_LDNS=1 -DUSE_BSM_AUDIT=1 -DHAVE_GETAUDIT_ADDR=1 -DUSE_BLACKLIST=1 -I/root/git/freebsd/contrib/blacklist/include -include
>  krb5_config.h -DLIBWRAP=1 -DXAUTH_PATH=\"/usr/local/bin/xauth\" -g  -std=gnu99 -fstack-protector-strong -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautologic
> al-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum -Wno-knr-promoted-pa
> rameter -Wno-parentheses  -fcolor-diagnostics -Qunused-arguments   -L/scratch/obj/root/git/freebsd/amd64.amd64/lib/libblacklist  /root/git/freebsd/crypto/openssh/moduli.c  -o /root/git/freebsd/crypto/op
> enssh/moduli
> /usr/bin/ld: error: undefined symbol: main
>>>> referenced by crt1.c:74 (/usr/src/lib/csu/amd64/crt1.c:74)

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20180816/a3c93b9b/attachment.sig>