svn commit: r337857 - in head: bin/csh bin/sh etc

[Ravi Pokala]

-----Original Message-----
From: <owner-src-committers at freebsd.org> on behalf of Brad Davis <brd at FreeBSD.org>
Date: 2018-08-15, Wednesday at 10:18
To: Ravi Pokala <rpokala at freebsd.org>, <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn-src-head at freebsd.org>
Subject: Re: svn commit: r337857 - in head: bin/csh bin/sh etc

> On Wed, Aug 15, 2018, at 11:17 AM, Ravi Pokala wrote:
>> Brad,
>> 
>> -----Original Message-----
>> From: <owner-src-committers at freebsd.org> on behalf of Brad Davis 
>> <brd at FreeBSD.org>
>> Date: 2018-08-15, Wednesday at 09:22
>> To: <src-committers at freebsd.org>, <svn-src-all at freebsd.org>, <svn-src-
>> head at freebsd.org>
>> Subject: svn commit: r337857 - in head: bin/csh bin/sh etc
>> 
>>> Author: brd
>>> Date: Wed Aug 15 16:22:12 2018
>>> New Revision: 337857
>>> URL: https://svnweb.freebsd.org/changeset/base/337857
>>> 
>>> Log:
>>>   Fix build after r337849
>>>   
>>>   This moves the symlink creation to after where the files are installed.
>>>   
>>>   This also inverts the shell change so that it only happens if MK_TCSH is on.
>> ...
>>> Modified: head/etc/master.passwd
>>> ==============================================================================
>>> --- head/etc/master.passwd	Wed Aug 15 16:16:59 2018	(r337856)
>>> +++ head/etc/master.passwd	Wed Aug 15 16:22:12 2018	(r337857)
>>> @@ -1,6 +1,6 @@
>>>  # $FreeBSD$
>>>  #
>>> -root::0:0::0:0:Charlie &:/root:/bin/csh
>>> +root::0:0::0:0:Charlie &:/root:/bin/sh
>>>  toor:*:0:0::0:0:Bourne-again Superuser:/root:
>>>  daemon:*:1:1::0:0:Owner of many system processes:/root:/usr/sbin/nologin
>>>  operator:*:2:5::0:0:System &:/:/usr/sbin/nologin
>> 
>> Woah! Changing the root shell wasn't mentioned in the change 
>> description, has nothing to do with fixing r337849, and is a *HUGE* POLA 
>> violation. At the very least, a change of this magnitude needs public 
>> discussion, and even if the community agreed, it would also require an 
>> UPDATING message and relnote.
>> 
>> Please revert this change to master.passwd immediately.
> 
> Hi Ravi,
> 
> Please, look closer.  It doesn't change what is actually installed in either case, it just inverts the logic.

This is master.passwd; it doesn't contain any logic, only data. Is there a different master.passwd somewhere that's used when MK_TCSH is on?

Oh, I see! bin/csh/Makefile does some `sed'ing. But it's not clear at all why you added the (incorrect) `sed'ing in r337849 in the first place. root's shell should be /bin/csh in master.passwd, and left alone. Maybe, if *csh* -- not *tcsh* -- were disabled, then `sed'ing to make root's shell /bin/sh would make sense. But I can't think of any reason master.passwd would start off with /bin/sh rather than /bin/csh.

What am I missing?

Thanks,

Ravi

> Regards,
> Brad Davis