svn commit: r337773 - in head/sys/amd64: amd64 include

[Alexey Dokuchaev]

On Tue, Aug 14, 2018 at 04:37:15PM +0000, Konstantin Belousov wrote:
> New Revision: 337773
> URL: https://svnweb.freebsd.org/changeset/base/337773
> 
> Log:
>   amd64: ensure that curproc->p_vmspace pmap always matches PCPU
>   curpmap.
>   
>   When performing context switch on a machine without PCID, if current
>   %cr3 equals to the new pmap %cr3, which is typical for kernel_pmap
>   vs. kernel process, I overlooked to update PCPU curpmap value.  Remove
>   check for %cr3 not equal to pm_cr3 for doing the update.  It is
>   believed that this case cannot happen at all, due to other changes in
>   this revision.
> ...
> -	} else if (cr3 != pmap->pm_cr3) {
> +	} else {
>  		load_cr3(pmap->pm_cr3);

If this case cannot happen at all, would it make sense to assert it?

./danfe