svn commit: r337758 - head/sys/x86/x86

Rodney W. Grimes freebsd at pdx.rh.CN85.dnsmgr.net
Tue Aug 14 15:28:10 UTC 2018


> Author: markj
> Date: Tue Aug 14 14:50:06 2018
> New Revision: 337758
> URL: https://svnweb.freebsd.org/changeset/base/337758
> 
> Log:
>   Explain why we aren't using memcpy().
>   
>   Reported by:	jmg
>   X-MFC with:	r337715
>   Sponsored by:	The FreeBSD Foundation
> 
> Modified:
>   head/sys/x86/x86/ucode.c
> 
> Modified: head/sys/x86/x86/ucode.c
> ==============================================================================
> --- head/sys/x86/x86/ucode.c	Tue Aug 14 14:19:57 2018	(r337757)
> +++ head/sys/x86/x86/ucode.c	Tue Aug 14 14:50:06 2018	(r337758)
> @@ -344,6 +344,7 @@ ucode_load_bsp(uintptr_t free)
>  		match = loader->match(fileaddr, &len);
>  		if (match != NULL) {
>  			addr = map_ucode(free, len);
> +			/* We can't use memcpy() before ifunc resolution. */

NVM my previous email, and thank you.

>  			for (i = 0; i < len; i++)
>  				addr[i] = match[i];
>  			match = addr;

-- 
Rod Grimes                                                 rgrimes at freebsd.org


More information about the svn-src-all mailing list