svn commit: r337689 - head/sys/dev/ipmi

Justin Hibbits jhibbits at FreeBSD.org
Sun Aug 12 20:33:56 UTC 2018


Author: jhibbits
Date: Sun Aug 12 20:33:55 2018
New Revision: 337689
URL: https://svnweb.freebsd.org/changeset/base/337689

Log:
  ipmi/opal: Enable polled mode and proper callback
  
  Fix a NULL dereference that would occur any time an ioctl() was done, due to a
  missing ipmi_enqueue_request callback.  Just use the default for now, until we
  decide to properly enable IPMI interrupts.
  
  Reported by:	kbowling

Modified:
  head/sys/dev/ipmi/ipmi_opal.c

Modified: head/sys/dev/ipmi/ipmi_opal.c
==============================================================================
--- head/sys/dev/ipmi/ipmi_opal.c	Sun Aug 12 14:05:15 2018	(r337688)
+++ head/sys/dev/ipmi/ipmi_opal.c	Sun Aug 12 20:33:55 2018	(r337689)
@@ -210,6 +210,8 @@ opal_ipmi_attach(device_t dev)
 	}
 	sc->ipmi.ipmi_startup = opal_ipmi_startup;
 	sc->ipmi.ipmi_driver_request = opal_ipmi_driver_request;
+	sc->ipmi.ipmi_enqueue_request = ipmi_polled_enqueue_request;
+	sc->ipmi.ipmi_driver_requests_polled = 1;
 	sc->ipmi.ipmi_dev = dev;
 
 	sc->sc_msg = malloc(sizeof(struct opal_ipmi_msg) + IPMI_MAX_RX, M_IPMI,


More information about the svn-src-all mailing list