svn commit: r337505 - head/bin/dd

Kyle Evans kevans at freebsd.org
Thu Aug 9 04:16:43 UTC 2018


On Wed, Aug 8, 2018 at 8:15 PM, Warner Losh <imp at bsdimp.com> wrote:
>
>
> On Wed, Aug 8, 2018 at 7:01 PM, Kyle Evans <kevans at freebsd.org> wrote:
>>
>> On Wed, Aug 8, 2018 at 7:58 PM, Eitan Adler <lists at eitanadler.com> wrote:
>> > On Wed, 8 Aug 2018 at 14:37, Kyle Evans <kevans at freebsd.org> wrote:
>> >> +/* ARGSUSED */
>> >
>> > We've been slowly delintifying system utilities. Why do we still keep
>> > these comments?
>> >
>>
>> This is consistent with the style of the file, so I didn't object.
>> I'd rather do another pass later to de-lintify the whole thing rather
>> than nitpick at this patch for some otherwise harmless and matching
>> comments. =)
>
>
> It appears to be from NetBSD upstream, so removing it would be pointless
> churn that makes things harder to merge.
>

Poking at NetBSD now that I have time, it doesn't look like they
actually have this feature. They have progress=<n> to output a dog
every n blocks, but apparently not one that actually does a
single-line summary every second like this and GNU dd (with the same
status=progress flag).


More information about the svn-src-all mailing list