svn commit: r336047 - in head/sys: amd64/include i386/include sys

Gleb Smirnoff glebius at freebsd.org
Fri Aug 3 22:27:41 UTC 2018


  Hi Konstantin,

On Fri, Jul 06, 2018 at 07:50:44PM +0000, Konstantin Belousov wrote:
K> Author: kib
K> Date: Fri Jul  6 19:50:44 2018
K> New Revision: 336047
K> URL: https://svnweb.freebsd.org/changeset/base/336047
K> 
K> Log:
K>   Expand x86 struct pcpus to UMA_PCPU_ALLOC_SIZE AKA PAGE_SIZE.
K>   
K>   This restores counters(9) operation.
K>   Revert r336024. Improve assert of pcpu size on x86.
K>   
K>   Reviewed by:	mmacy
K>   Sponsored by:	The FreeBSD Foundation
K>   Differential revision:	https://reviews.freebsd.org/D16163

Since this has been broken already several times as people who edit
surrounding code don't understand the magic, and since now we round
the struct pcpu size to PAGE_SIZE anyways, what about stop carefully
craft the padding and just change alignment of struct pcpu to PAGE_SIZE?

-- 
Gleb Smirnoff


More information about the svn-src-all mailing list