svn commit: r332813 - head/sys/fs/nfsclient

Conrad Meyer cem at freebsd.org
Fri Apr 20 18:57:28 UTC 2018


On Fri, Apr 20, 2018 at 4:38 AM, Rick Macklem <rmacklem at freebsd.org> wrote:
> Author: rmacklem
> Date: Fri Apr 20 11:38:29 2018
> New Revision: 332813
> URL: https://svnweb.freebsd.org/changeset/base/332813
>
> Log:
>   Fix use of pointer after being set NULL.
>
>   Using a pointer after setting it NULL is probably not a good plan.
>   Spotted by inspection during changes for Flexible File Layout Ioerr handling.
>   This code path obviously isn't normally executed.

This is definitely the kind of thing that Coverity can catch.  I would
strongly encourage you to take a look at the Coverity scan output for
nfsclient.  There are a bunch of reports, many of which I have
confirmed are valid.

Best,
Conrad


More information about the svn-src-all mailing list