svn commit: r332365 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Allan Jude allanjude at freebsd.org
Wed Apr 11 04:52:07 UTC 2018


On 2018-04-10 09:56, Mark Johnston wrote:
> Author: markj
> Date: Tue Apr 10 13:56:06 2018
> New Revision: 332365
> URL: https://svnweb.freebsd.org/changeset/base/332365
> 
> Log:
>   Set zfs_arc_free_target to v_free_target.
>   
>   Page daemon output is now regulated by a PID controller with a setpoint
>   of v_free_target. Moreover, the page daemon now wakes up regularly
>   rather than waiting for a wakeup from another thread. This means that
>   the free page count is unlikely to drop below the old
>   zfs_arc_free_target value, and as a result the ARC was not readily
>   freeing pages under memory pressure. Address the immediate problem by
>   updating zfs_arc_free_target to match the page daemon's new behaviour.
>   
>   Reported and tested by:	truckman
>   Discussed with:	jeff
>   X-MFC with:	r329882
>   Differential Revision:	https://reviews.freebsd.org/D14994
> 

On a somewhat unrelated note, can we rename this sysctl and change to be
counted in bytes? When users are tuning ZFS, every other ZFS value is in
bytes, not pages.

Maybe keep the currently variable as it is, in pages, and adjust it by
dividing the user set value by the page size.

The current name is great, but I wouldn't want anyone to end up setting
it to 4096x the value they actually want if we just changed it out from
under them.

-- 
Allan Jude

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20180411/39c01847/attachment.sig>


More information about the svn-src-all mailing list